Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translators for the sbcu and dbcu sectors #116

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MJKirk
Copy link
Contributor

@MJKirk MJKirk commented Nov 12, 2024

Relies on my PR in wcxf-bases (wcxf/wcxf-bases#10) adding these new sectors

@MJKirk MJKirk marked this pull request as draft November 12, 2024 14:18
@MJKirk
Copy link
Contributor Author

MJKirk commented Nov 12, 2024

Converted to a draft, since the wcxf-bases submodule will need to be updated as well before this should be merged

@DavidMStraub
Copy link
Member

Hi Matthew, I can click the "merge" button on the bases PR but I have not reviewed it. I assume it's just a copy/paste of an existing sector with different flavour indices?

@MJKirk
Copy link
Contributor Author

MJKirk commented Nov 12, 2024

Yep, it is just a copy/paste, so that should be a trivial approval. I just eyeballed it again as well and it looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants